refactor: Fix gocritic.paramTypeCombine lint issues by alexandear · Pull Request #3655

refactor: Fix gocritic.paramTypeCombine lint issues by alexandear · Pull Request #3655 · google/go-github

Copy link

Contributor

alexandear commented
Jul 28, 2025

This PR combines function parameters by type (with the help of gocritic.paramTypeCombine). See #3654 (comment)

alexandear mentioned this pull request

Jul 28, 2025

refactor!: Change GitService methods to pass required params by-value instead of by-ref #3654

Merged

alexandear force-pushed the refactor/param-type-combine branch 2 times, most recently from 292556e to 3e2e68c Compare

July 28, 2025 15:13

refactor: Fix gocritic.paramTypeCombine lint issues

c77318b

alexandear force-pushed the refactor/param-type-combine branch from 3e2e68c to c77318b Compare

July 28, 2025 15:15

gmlewis approved these changes Jul 28, 2025

View reviewed changes

Copy link

Collaborator

gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @alexandear!
LGTM.
Merging.

Copy link

codecov bot commented
Jul 28, 2025
•

edited

Loading

Codecov Report

❌ Patch coverage is 92.85714% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.25%. Comparing base (ac631dc) to head (c77318b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
...xample/codespaces/newreposecretwithxcrypto/main.go	0.00%	2 Missing ⚠️
example/newreposecretwithxcrypto/main.go	0.00%	2 Missing ⚠️
...xample/codespaces/newusersecretwithxcrypto/main.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #3655   +/-   ##
=======================================
  Coverage   91.25%   91.25%           
=======================================
  Files         184      184           
  Lines       16311    16311           
=======================================
  Hits        14884    14884           
  Misses       1245     1245           
  Partials      182      182

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow: