chore: Format code with gofumpt by alexandear · Pull Request #3689 · google/go-github

@alexandear

This PR enables gofumpt formatter and formats all code with golangci-lint fmt.

gofumpt detects missing empty lines between functions like in #3687 (comment)

@alexandear

gmlewis

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful, @alexandear! Thank you for doing this!
Of all the changes, the only one that I really don't like is the very last one: 0600 => 0o600 but I can live with that one. 😂

@gmlewis

@willnorris - suddenly, with this one PR, I lost the ability to approve the two workflows above (EDIT:) below.
Are you able to tell if I am no longer officially a maintainer of this repo, or do I need to get the OSPO team involved?
Or maybe GitHub itself just had some sort of regression and I need to wait it out? 😂

EDIT: It looks like I may no longer have write access to the repo maybe? I'm not sure how I lost it.

@gmlewis

Ah! I just received this email, which is BOGUS, as I have ALWAYS had two-factor authentication enabled ever since it was first introduced!!!

So I think GitHub itself just had a MAJOR regression, unfortunately.

BOGUS-2025-08-18_13-24-30 two-factor-proof-2025-08-18_13-26-17

@gmlewis

@google-admin - could you please add me back to the "Google" organization for this repo, as GitHub seems to have had some sort of glitch that kicked me out.

@willnorris

Yeah, that's weird. It looks like I have basically the same security config as you (couple of passkeys, etc), and I still have access. (Also, when did GitHub add Login with Google? That's interesting... I never noticed that before)

@gmlewis

Yeah, that's weird. It looks like I have basically the same security config as you (couple of passkeys, etc), and I still have access.

Weird indeed. Thanks for the confirmation.

(Also, when did GitHub add Login with Google? That's interesting... I never noticed that before)

Actually, I don't even remember. It must have been years ago.

This was referenced

Aug 18, 2025

@gmlewis

@google-admin - could you please add me back to the "Google" organization for this repo, as GitHub seems to have had some sort of glitch that kicked me out.

@google-admin - it has now been about 2 weeks that I have not had write access to this repo.

Can you please restore my access?

@gmlewis

@google-admin - could you please add me back to the "Google" organization for this repo, as GitHub seems to have had some sort of glitch that kicked me out.

@google-admin - it has now been about 3 weeks that I have not had write access to this repo.

Can you please restore my access?

@gmlewis

Thank you, @google-admin for restoring my access to this repo! It is greatly appreciated!

TIL: My access was revoked because not only did I have "Passkeys" two-factor authentication enabled, but I ALSO had "SMS" two-factor authentication enabled. Apparently, my access was revoked because I had "SMS" 2FA enabled (which is considered less secure). I could not accept the invite for this repo until I REMOVED "SMS 2FA". Once I did that, I was able to accept the invite.

gmlewis

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.