feat: Add two new Secret Scanning API endpoints by Not-Dhananjay-Mishra · Pull Request #3687

feat: Add two new Secret Scanning API endpoints by Not-Dhananjay-Mishra · Pull Request #3687 · google/go-github

Conversation

This PR adds support for two new Secret Scanning API endpoints that are currently missing from the go-github library

Implement

POST /repos/{owner}/{repo}/secret-scanning/push-protection-bypasses
GET /repos/{owner}/{repo}/secret-scanning/scan-history

Changes

Add CreatePushProtectionBypass method
Add GetScanHistory method
Made two new struct for PushProtectionBypasses method - PushProtectionBypassRequest and PushProtectionBypass
Made three new struct for ScanHistory method - Scan, CustomPatternScan and SecretScanningResponse

Issue - #3686

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.37%. Comparing base (29b4fac) to head (be5f36d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3687      +/-   ##
==========================================
+ Coverage   91.36%   91.37%   +0.01%     
==========================================
  Files         187      187              
  Lines       16734    16760      +26     
==========================================
+ Hits        15289    15315      +26     
  Misses       1257     1257              
  Partials      188      188

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexandear Thanks for the suggestions. I have changed the method names. Please let me know if you have any other suggestions.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Not-Dhananjay-Mishra.
This is a good start. Please address the findings and then we should be ready for a second LGTM+Approval from any other contributor to this repo before merging.

Thanks @gmlewis for the feedback! I have fixed all the findings. Sorry for the extra back and forth code review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Not-Dhananjay-Mishra!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

Just FYI - suddenly I have lost write access to this repo, like in #3689... so I can no longer approve the workflows and need to find out what is going on... this may take some time to resolve... I apologize for the inconvenience.

@alexandear i have done some changes can u please check them.

gmlewis changed the title ~~feat: Add GitHub two new Secret Scanning API endpoints~~ feat: Add two new Secret Scanning API endpoints

Oct 7, 2025