feat: Immutable releases support by scop · Pull Request #3725 · google/go-github
scop
mentioned this pull request
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.11%. Comparing base (1b53270) to head (bf4be06).
⚠️ Report is 11 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@ ## master #3725 +/- ## ======================================= Coverage 91.11% 91.11% ======================================= Files 187 187 Lines 16686 16686 ======================================= Hits 15204 15204 Misses 1295 1295 Partials 187 187
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Thank you, @scop!
Can you please fix the linter errors, and then we will review the PR?
| TarballURL: Ptr("http://tarballurl/"), | ||
| Author: &User{Name: Ptr("octocat")}, | ||
| NodeID: Ptr("nodeid"), | ||
| Immutable: Ptr(false), |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This added line is in a section commented as "Fields to be removed". It contains a bunch of other fields that I suppose one cannot set when creating a release, such as the release id, created at, published at, etc. IIUC the purpose of having these set here is to verify that we will not be sending them in create requests even if they're set.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scop
deleted the
feat/immutable-release
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters