refactor!: Replace `Edit` with `Update` in permissions method names by zyfy29 · Pull Request #3731 · google/go-github
Conversation
BREAKING CHANGE: Permissions-related methods are renamed from Edit* to Update*.
Rename the methods EditXXX to UpdateXXX for the permissions related apis
accomplish #3679 (comment)
gmlewis
changed the title
refactor: replace Edit with Update in permissions method names
refactor!: Replace Edit with Update in permissions method names
Codecov Report
❌ Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.11%. Comparing base (1b53270) to head (6c88d60).
⚠️ Report is 8 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| example/actionpermissions/main.go | 0.00% | 2 Missing ⚠️ |
Additional details and impacted files
@@ Coverage Diff @@ ## master #3731 +/- ## ======================================= Coverage 91.11% 91.11% ======================================= Files 187 187 Lines 16686 16686 ======================================= Hits 15204 15204 Misses 1295 1295 Partials 187 187
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmlewis Thanks, it's nice to see you back!
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters