fix: Ignore unset `AllowedMergeMethods` field by stevehipwell · Pull Request #3905 · google/go-github
This PR fixes a bug where the merge methods for a pull request ruleset rule always need to be defined instead of being able to be unset.
gmlewis
changed the title
fix: Ignore unset ruleset pr merge methods field
fix: Ignore unset AllowedMergeMethods field
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.44%. Comparing base (ce49609) to head (377e05b).
⚠️ Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@ ## master #3905 +/- ## ======================================= Coverage 92.44% 92.44% ======================================= Files 203 203 Lines 14927 14927 ======================================= Hits 13799 13799 Misses 926 926 Partials 202 202
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gmlewis it'd be useful if we could get this released?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters