fix!: Divide `PackageGetAllVersions` into two separate methods `ListPackageVersions` and `ListUserPackageVersions` by Not-Dhananjay-Mishra · Pull Request #4014 · google/go-github
Conversation
BREAKING CHANGE: PackageGetAllVersions is now divided into ListPackageVersions and ListUserPackageVersions.
PackageGetAllVersions handles two endpoints one of them doesn't support pagination acc to docs also its Iterator doesn't get generated because its method name does not contain List as prefix.
Updates : #3976
gmlewis
changed the title
fix!: Divided
fix!: Divide PackageGetAllVersions into two separate methods ListPackageVersions and ListPackageVersionsForUserPackageGetAllVersions into two separate methods ListPackageVersions and ListPackageVersionsForUser
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.04%. Comparing base (e3c4fb5) to head (d828771).
⚠️ Report is 1 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@ ## master #4014 +/- ## ======================================= Coverage 94.04% 94.04% ======================================= Files 207 207 Lines 19151 19174 +23 ======================================= + Hits 18010 18033 +23 Misses 939 939 Partials 202 202
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not-Dhananjay-Mishra
changed the title
fix!: Divide
fix!: Divide PackageGetAllVersions into two separate methods ListPackageVersions and ListPackageVersionsForUserPackageGetAllVersions into two separate methods ListPackageVersions and ListUserPackageVersions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters