Reset Bounds when surrounding div resizes by RUPOJS · Pull Request #219

Reset Bounds when surrounding div resizes by RUPOJS · Pull Request #219 · google-map-react/google-map-react

rupesh.singh added 2 commits

August 22, 2016 15:45

Wow! Super!
I'll check it later today, but what I see now is really cool.

Please add /* eslint-disable */ at the top of third-party libs, to pass through the travis checks

Thanks @istarkov .
I'll add that in next commit. Looking forward for your valuable feedback :)

rupesh.singh added 5 commits

August 22, 2016 17:18

		onChildMouseEnter={onChildMouseEnter}
		onChildMouseLeave={onChildMouseLeave}
		resetBoundsOnResize={true}
		apiKey={"AIzaSyC-BebC7ChnHPzxQm7DAHYFMCqR5H3Jlps"}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you really want to share your API key with all world?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a dummy project with basic settings, so no harms in sharing it.

		@@ -0,0 +1,51 @@
		/* eslint-disable */

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the last step is to delete this file?

I found how to trigger internal gmap resize
please check that it will fix all issues

Please replace your _mapDomResizeCallback with this

  _mapDomResizeCallback = () => {
    this.resetSizeOnIdle_ = true;
    if (this.maps_) {
      this.maps_.event.trigger(this.map_, 'resize');
    }
  }

looks like it works perfectly for me

Hi @istarkov I did the suggested changes in the last commit :)

Thank you!!!
Really good PR, and solve a real problem

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock bot locked as resolved and limited conversation to collaborators

Dec 1, 2019