Home Original page

Stop capturing all touch events and use built in google maps support by yoadsn · Pull Request #334 · google-map-react/google-map-react

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@yoadsn

Copy link Copy Markdown

Contributor

@yoadsn yoadsn commented

Mar 10, 2017

This should solve #297 and reverts the changes from #233.
The purpose of this PR is to expose the built in google maps functionality for handling touch interaction with the map and removing the previous handling which captured all touch events and emulated a "greedy" approach where the other elements on the page cannot respond to those touch events.

yoadsn added 3 commits

March 10, 2017 09:02
Using the built in support from google maps would make the component more
mobile friendly.

This reverts commit 7d1180c.

@istarkov

Copy link Copy Markdown

Collaborator

Super, thank you!

@istarkov istarkov merged commit 956c0ca into google-map-react:master

Mar 10, 2017

@lock

Copy link Copy Markdown

lock bot commented

Dec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators

Dec 1, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yoadsn @istarkov