docs - fix outdated method on SearchBox example by huygn · Pull Request #343 · google-map-react/google-map-react
Navigation Menu
{{ message }}
google-map-react / google-map-react Public
- Notifications You must be signed in to change notification settings
- Fork 856
Merged
docs - fix outdated method on SearchBox example#343
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrom
huygn:patch-1
docs - fix outdated method on SearchBox example#343
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrom
huygn:patch-1
Conversation
Copy link Copy Markdown
Contributor
huygn
commented
Mar 17, 2017
huygn
commented
Using this.searchBox.removeListener will throw removeListener is not a function error and results in component cannot unmount.
Update with google.maps.event.clearInstanceListeners method found on google map docs: // https://developers.google.com/maps/documentation/javascript/events#removing
itsmichaeldiego approved these changes Dec 20, 2017
itsmichaeldiego
merged commit
d83352f
into
google-map-react:master
Copy link Copy Markdown
lock
bot
commented
Dec 1, 2019
lock bot commented
Dec 1, 2019This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
lock
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.