docs - fix outdated method on SearchBox example by huygn · Pull Request #343 · google-map-react/google-map-react

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@huygn

Copy link Copy Markdown

Contributor

@huygn huygn commented

Mar 17, 2017

Using this.searchBox.removeListener will throw removeListener is not a function error and results in component cannot unmount.

Update with google.maps.event.clearInstanceListeners method found on google map docs: // https://developers.google.com/maps/documentation/javascript/events#removing

skrobek reacted with thumbs up emoji

@itsmichaeldiego itsmichaeldiego merged commit d83352f into google-map-react:master

Dec 20, 2017

@lock

Copy link Copy Markdown

lock bot commented

Dec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators

Dec 1, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@itsmichaeldiego itsmichaeldiego itsmichaeldiego approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@huygn @itsmichaeldiego