Renamed pointer-geometry dependency to @mapbox/pointer-geometry by eko · Pull Request #437 · google-map-react/google-map-react
Navigation Menu
{{ message }}
google-map-react / google-map-react Public
- Notifications You must be signed in to change notification settings
- Fork 856
Closed
eko wants to merge 1 commit intogoogle-map-react:masterfrom
Closed
Renamed pointer-geometry dependency to @mapbox/pointer-geometry#437
eko wants to merge 1 commit intogoogle-map-react:masterfrom
Renamed pointer-geometry dependency to @mapbox/pointer-geometry#437
eko wants to merge 1 commit intogoogle-map-react:masterfrom
Conversation
Copy link Copy Markdown
eko
commented
Aug 21, 2017
eko
commented
Hello,
This dependency has been renamed so when running npm install, we get:
$ npm install
npm WARN deprecated point-geometry@0.0.0: This module has moved: please install @mapbox/point-geometry instead
Thank you
Copy link Copy Markdown
Horat1us
commented
Sep 4, 2017
Horat1us commented
Sep 4, 2017+1 Why not to merge this PR?
Copy link Copy Markdown
rmacqueen
commented
Sep 9, 2017
rmacqueen commented
Sep 9, 2017Agreed, please merge. Warnings are quite annoying and is easy fix
Copy link Copy Markdown
Collaborator
istarkov
commented
Sep 9, 2017
istarkov commented
Sep 9, 2017has anyone checked releases log of pointer geometry, I have no time to check this
Copy link Copy Markdown
Horat1us
commented
Sep 9, 2017
Horat1us commented
Sep 9, 2017They just add some methods:
https://github.com/mapbox/point-geometry/blob/master/HISTORY.md
Copy link Copy Markdown
Author
eko
commented
Sep 9, 2017
eko commented
Sep 9, 2017+1, I don't see any BC break
Copy link Copy Markdown
Contributor
Exomnius
commented
Oct 9, 2017
Exomnius commented
Oct 9, 2017Seems ok. Please merge this for next version release.
Copy link Copy Markdown
Member
itsmichaeldiego
commented
Dec 20, 2017
itsmichaeldiego commented
Dec 20, 2017
itsmichaeldiego
closed this
Copy link Copy Markdown
lock
bot
commented
Dec 1, 2019
lock bot commented
Dec 1, 2019This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
lock
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
6 participants