notify call back of load failure by acellam · Pull Request #479 · google-map-react/google-map-react
Navigation Menu
{{ message }}
google-map-react / google-map-react Public
- Notifications You must be signed in to change notification settings
- Fork 856
Merged
notify call back of load failure#479
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrom
acellam:master
notify call back of load failure#479
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrom
acellam:master
Conversation
Copy link Copy Markdown
Contributor
acellam
commented
Dec 20, 2017
acellam
commented
When the google fails to load due to no internet, the call back should be notified so that appropriate UI can be shown
Copy link Copy Markdown
Member
itsmichaeldiego
left a comment
•
edited
Loading
itsmichaeldiego
left a comment
•
edited
Loading
edited
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check Travis errors in here
When the google fails to load due to no internet, the call back should be notified so that appropriate UI can be shown
Copy link Copy Markdown
Contributor Author
acellam
commented
Dec 25, 2017
acellam commented
Dec 25, 2017@itsmichaeldiego thanks for spotting the bug 🐛 . It is because i edited the file on github and not my work station but am glad that the unit tests got me :) i have done a forced push with the correction
itsmichaeldiego
merged commit
7814901
into
google-map-react:master
Copy link Copy Markdown
lock
bot
commented
Dec 1, 2019
lock bot commented
Dec 1, 2019This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
lock
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants