Fix for usage from China by emilpalsson · Pull Request #494

Fix for usage from China by emilpalsson · Pull Request #494 · google-map-react/google-map-react

Use China specific API URL if setting bootstrapURLKeys.region to 'cn'.

Fixes #493

Emil Palsson added 2 commits

January 16, 2018 08:35

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I approve

@emilpalsson Thanks for this, it is looking good, would you mind adding this to the docs? As soon as you do that I will release a new version fixing this.

		''
		);

		const url = bootstrapURLKeys.region === 'cn'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about other regions ?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jooj123 I believe the only region that has a problem with this is China. But we could confirm

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly, China is the only region mentioned on the Google Maps FAQ (see link in the issue), and the only region I've experienced problems with.

@itsmichaeldiego Great! Of course, I'll see if I can find a good spot for this in the docs right now.

Emil Palsson added 2 commits

January 18, 2018 08:15

@itsmichaeldiego I've added this to the docs, let me know if you want me to structure it differently. I also added a toLocaleLowerCase() for case insensitivity.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work dude!

Looks like that if region is not set — it leads to uncaught Error now, with 0.28.0 release

I'm setting up my GoogleMap component like this:

      <GoogleMap
        bootstrapURLKeys={{
          key: GOOGLE_MAPS_API_KEY,
          language: intl.locale,
        }}
//...

@romanenko Yes, I'm sorry for this. There is already a new PR to fix this (#496).

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock bot locked as resolved and limited conversation to collaborators

Dec 1, 2019