Home Original page

Refactor code style by itsmichaeldiego · Pull Request #533 · google-map-react/google-map-react

@itsmichaeldiego

This pr includes:

  • Fix some eslint styling
  • Update recompose to latest version
  • Use object destruction to import multiple child modules from one single module (recompose & lodash)

itsmichaeldiego
const BASE_URL = 'https://maps';
const DEFAULT_URL = `${BASE_URL}.googleapis.com`;
const API_PATH = '/maps/api/js?callback=_$_google_map_initialize_$_';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

itsmichaeldiego

}

let queryString = Object.keys(bootstrapURLKeys).reduce(
let params = Object.keys(bootstrapURLKeys).reduce(

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word params makes more sense than queryString, as they're actually params

itsmichaeldiego

withContext,
withProps,
withPropsOnChange,
} from 'recompose';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way of importing things looks clearer

This was referenced

Mar 11, 2018

@lock

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators

Dec 1, 2019