Avoid null error by asundlihardig · Pull Request #570 · google-map-react/google-map-react

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@asundlihardig

Copy link Copy Markdown

Contributor

Avoid the error "Cannot read property 'removeEventListener' of null"

Avoid the error "Cannot read property 'removeEventListener' of null"

@itsmichaeldiego

Copy link Copy Markdown

Member

@asundlihardig Could you provide a screenshot showing the error ?

@asundlihardig

Copy link Copy Markdown

Contributor Author

I'm sorry @itsmichaeldiego . The error was reported through Sentry.io

@itsmichaeldiego

Copy link Copy Markdown

Member

@asundlihardig Sorry I can't merge this without you showing me how this is blocking you or where is the error. There are thousands of places in the code where we could add defensive programming, I need to know why adding it here would make the difference.

@itsmichaeldiego itsmichaeldiego force-pushed the master branch 2 times, most recently from 16436be to f6bb003 Compare

May 13, 2018 19:20

@itsmichaeldiego

Copy link Copy Markdown

Member

@asundlihardig Looking forward to hear back from you! Would like to merge this if its an issue for the users.

@itsmichaeldiego itsmichaeldiego merged commit d6576f2 into google-map-react:master

May 25, 2018

@lock

Copy link Copy Markdown

lock bot commented

Dec 1, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators

Dec 1, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@itsmichaeldiego itsmichaeldiego itsmichaeldiego approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asundlihardig @itsmichaeldiego