Avoid null error by asundlihardig · Pull Request #570 · google-map-react/google-map-react
Navigation Menu
{{ message }}
google-map-react / google-map-react Public
- Notifications You must be signed in to change notification settings
- Fork 856
Merged
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrom
May 25, 2018Merged
Avoid null error#570
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrom
Avoid null error#570
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrom
Conversation
Copy link Copy Markdown
Contributor
asundlihardig
commented
May 3, 2018
asundlihardig
commented
Avoid the error "Cannot read property 'removeEventListener' of null"
Avoid the error "Cannot read property 'removeEventListener' of null"
Copy link Copy Markdown
Member
itsmichaeldiego
commented
May 8, 2018
itsmichaeldiego commented
May 8, 2018@asundlihardig Could you provide a screenshot showing the error ?
Copy link Copy Markdown
Contributor Author
asundlihardig
commented
May 11, 2018
asundlihardig commented
May 11, 2018I'm sorry @itsmichaeldiego . The error was reported through Sentry.io
Copy link Copy Markdown
Member
itsmichaeldiego
commented
May 11, 2018
itsmichaeldiego commented
May 11, 2018@asundlihardig Sorry I can't merge this without you showing me how this is blocking you or where is the error. There are thousands of places in the code where we could add defensive programming, I need to know why adding it here would make the difference.
itsmichaeldiego
force-pushed
the
master
branch
2 times, most recently
from
16436be to
f6bb003
Compare
Copy link Copy Markdown
Member
itsmichaeldiego
commented
May 22, 2018
itsmichaeldiego commented
May 22, 2018@asundlihardig Looking forward to hear back from you! Would like to merge this if its an issue for the users.
itsmichaeldiego approved these changes May 25, 2018
itsmichaeldiego
merged commit
d6576f2
into
google-map-react:master
Copy link Copy Markdown
lock
bot
commented
Dec 1, 2019
lock bot commented
Dec 1, 2019This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
lock
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.