Move react-dom to dependencies by itsmichaeldiego · Pull Request #577 · google-map-react/google-map-react
Navigation Menu
{{ message }}
google-map-react / google-map-react Public
- Notifications You must be signed in to change notification settings
- Fork 856
Merged
Conversation
Copy link Copy Markdown
Member
itsmichaeldiego
commented
May 13, 2018
itsmichaeldiego
commented
React-dom is required by src/google_map.js. But it was not listed as peerDependency, because of this, we were not able to use Google-map-react in a project that does not have react-dom as a dependency.
itsmichaeldiego
force-pushed
the
fix-dependencies
branch
2 times, most recently
from
55322bd to
a53e2d3
Compare
itsmichaeldiego
force-pushed
the
fix-dependencies
branch
from
a53e2d3 to
ec5a8f6
Compare
itsmichaeldiego
merged commit
b7d61df
into
master
itsmichaeldiego
deleted the
fix-dependencies
branch
jooj123 reviewed May 30, 2018
| "prop-types": "^15.5.6", | ||
| "react": "^0.14.0 || ^15.0.0 || ^16.0.0" | ||
| "react": "^0.14.0 || ^15.0.0 || ^16.0.0", | ||
| "react-dom": "^16.0.0" |
Copy link Copy Markdown
Contributor
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be "react-dom": "^0.14.0 || ^15.0.0 || ^16.0.0" ?
Copy link Copy Markdown
lock
bot
commented
Dec 1, 2019
lock bot commented
Dec 1, 2019This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
lock
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants