Move dep for react-dom by jooj123 · Pull Request #592 · google-map-react/google-map-react
Navigation Menu
{{ message }}
google-map-react / google-map-react Public
- Notifications You must be signed in to change notification settings
- Fork 856
Merged
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrom
May 31, 2018Merged
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrom
itsmichaeldiego merged 1 commit intogoogle-map-react:masterfrom
Conversation
Copy link Copy Markdown
Contributor
jooj123
commented
May 30, 2018
jooj123
commented
react-dom should be a peerDep and not a dependancy
Consumers should be deciding if they want to include this as part of their bundle not the library
itsmichaeldiego approved these changes May 31, 2018
Copy link Copy Markdown
Member
itsmichaeldiego
left a comment
•
edited
Loading
itsmichaeldiego
left a comment
•
edited
Loading
edited
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work dude! This is getting merged and will be released in 1.0.4
itsmichaeldiego
merged commit
fc062a0
into
google-map-react:master
jooj123
deleted the
patch/fix-deps
branch
Copy link Copy Markdown
Contributor Author
jooj123
commented
Jun 1, 2018
jooj123 commented
Jun 1, 2018thanks @itsmichaeldiego 👍
moust
mentioned this pull request
Copy link Copy Markdown
Contributor Author
jooj123
commented
Jun 8, 2018
jooj123 commented
Jun 8, 2018@itsmichaeldiego any chance we can get this one released?
Copy link Copy Markdown
prasadhewage
commented
Jun 8, 2018
prasadhewage commented
Jun 8, 2018@itsmichaeldiego hey, can we have this change soon.
Copy link Copy Markdown
Member
itsmichaeldiego
commented
Jun 11, 2018
itsmichaeldiego commented
Jun 11, 2018@jooj123 @prasadhewage Sorry guys, I am in holidays in Greece and I haven't been that active.
I released this on v1.0.4
Cheers!
Copy link Copy Markdown
lock
bot
commented
Dec 1, 2019
lock bot commented
Dec 1, 2019This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
lock
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants