feat: Provide HttpTransport support for google certificates with apache HTTP client v5 (#2497) by ldetmer · Pull Request #2503 · googleapis/google-api-java-client
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!
-- conventional-commit-lint bot
https://conventionalcommits.org/
ldetmer
marked this pull request as ready for review
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, thanks! Just a few comments + a nit on the pom and docs
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The format checker will probably complain for a missing license header in this file.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you're looking at old version of the file?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, indeed! Please disregard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters