chore: drop support for PHP 7.4 by bshaffer · Pull Request #2562 · googleapis/google-api-php-client
Navigation Menu
{{ message }}
googleapis / google-api-php-client Public
- Notifications You must be signed in to change notification settings
- Fork 3.5k
Merged
Conversation
bshaffer
requested a review
from a team
bshaffer
requested a review
from Hectorhammett
Hectorhammett approved these changes May 16, 2024
Copy link Copy Markdown
Contributor
Hectorhammett
commented
May 16, 2024
Hectorhammett commented
May 16, 2024The 7.X tests are still running, Should we remove them? What is the protocol here @bshaffer
Copy link Copy Markdown
Contributor
vishwarajanand
commented
May 17, 2024
vishwarajanand commented
May 17, 2024README also needs to be changed:
google-api-php-client/README.md
Line 28 in 7e79f3d
| * [PHP 7.4 or higher](https://www.php.net/) |
Copy link Copy Markdown
Contributor
vishwarajanand
commented
May 17, 2024
vishwarajanand commented
May 17, 2024@Hectorhammett that is happening because php7.4 is mentioned in the repo settings. It can be fixed by removing it, but only admin can see/do this change.
vishwarajanand approved these changes May 17, 2024
Copy link Copy Markdown
Contributor
vishwarajanand
left a comment
vishwarajanand
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock
bshaffer added 2 commits
May 17, 2024 09:04
bshaffer
enabled auto-merge (squash)
bshaffer
merged commit
dae35df
into
main
bshaffer
deleted the
drop-php74
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants