chore: remove mentions of pycrypto by busunkim96 · Pull Request #799 · googleapis/google-api-python-client
Navigation Menu
{{ message }}
googleapis / google-api-python-client Public
- Notifications You must be signed in to change notification settings
- Fork 2.6k
Merged
chore: remove mentions of pycrypto#799
busunkim96 merged 2 commits intogoogleapis:masterfrom
chore: remove mentions of pycrypto#799
busunkim96 merged 2 commits intogoogleapis:masterfrom
Conversation
Copy link Copy Markdown
Contributor
pycrypto is no longer needed for development. tox.ini is unused as noxfile.py is used for testing.
Closes #797
label
Jan 14, 2020
busunkim96
requested a review
from leahecole
leahecole approved these changes Jan 14, 2020
Copy link Copy Markdown
leahecole
left a comment
leahecole
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if tests pass
busunkim96
changed the title
chore: remove mentions of pycrypto and unused tox.ini
chore: remove mentions of pycrypto
Copy link Copy Markdown
Contributor Author
busunkim96
commented
Jan 14, 2020
busunkim96 commented
Jan 14, 2020Kokoro configs haven't quite been moved over, hence the Kokoro - Build failed.
busunkim96
merged commit
360a516
into
googleapis:master
vorpal-buildbot
mentioned this pull request
parthea
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment