fix: update GOOGLE_API_USE_MTLS values by arithmetic1728 · Pull Request #940 · googleapis/google-api-python-client
Navigation Menu
{{ message }}
googleapis / google-api-python-client Public
- Notifications You must be signed in to change notification settings
- Fork 2.6k
Merged
Conversation
Copy link Copy Markdown
Contributor
arithmetic1728
commented
Jun 10, 2020
arithmetic1728
commented
Go client used lower case, so change the values to lower case in python apiary client.
label
Jun 10, 2020
arithmetic1728
requested a review
from busunkim96
busunkim96 approved these changes Jun 10, 2020
Copy link Copy Markdown
Contributor
busunkim96
left a comment
busunkim96
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is it worth making this case insensitive?
Copy link Copy Markdown
Contributor Author
arithmetic1728
commented
Jun 10, 2020
arithmetic1728 commented
Jun 10, 2020I think I will just use the lower case to be consistent with the Go implementation: https://github.com/googleapis/google-api-go-client/blob/master/transport/http/dial.go#L31-L35
arithmetic1728
merged commit
19908ed
into
master
arithmetic1728
deleted the
sijun-name
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment