feat: allow to use 'six.moves.collections_abc.Mapping' in 'client_options.from_dict()' by paul1319 · Pull Request #943 · googleapis/google-api-python-client

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@paul1319

Copy link Copy Markdown

Contributor

@paul1319 paul1319 commented

Jun 18, 2020

edited

Loading

@googlebot googlebot added the cla: yes

This human has signed the Contributor License Agreement.

label

Jun 18, 2020

@paul1319 paul1319 marked this pull request as ready for review

June 18, 2020 12:10

@paul1319 paul1319 requested a review from busunkim96

June 18, 2020 13:43
Copy link Copy Markdown

Contributor

@busunkim96 busunkim96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch @paul1319!

@busunkim96 busunkim96 merged commit 21af37b into master

Jun 18, 2020

gcf-merge-on-green bot pushed a commit that referenced this pull request

Jul 15, 2020
🤖 I have created a release \*beep\* \*boop\* 
---
## [1.10.0](https://www.github.com/googleapis/google-api-python-client/compare/v1.9.3...v1.10.0) (2020-07-15)


### Features

* allow to use 'six.moves.collections_abc.Mapping' in 'client_options.from_dict()' ([#943](https://www.github.com/googleapis/google-api-python-client/issues/943)) ([21af37b](https://www.github.com/googleapis/google-api-python-client/commit/21af37b11ea2d6a89b3df484e1b2fa1d12849510))
* Build universal wheels ([#948](https://www.github.com/googleapis/google-api-python-client/issues/948)) ([3e28a1e](https://www.github.com/googleapis/google-api-python-client/commit/3e28a1e0d47f829182cd92f37475ab91fa5e4afc))
* discovery supports retries ([#967](https://www.github.com/googleapis/google-api-python-client/issues/967)) ([f3348f9](https://www.github.com/googleapis/google-api-python-client/commit/f3348f98bf91a88a28bf61b12b95e391cc3be1ff)), closes [#848](https://www.github.com/googleapis/google-api-python-client/issues/848)


### Documentation

* consolidating and updating the Contribution Guide ([#964](https://www.github.com/googleapis/google-api-python-client/issues/964)) ([63f97f3](https://www.github.com/googleapis/google-api-python-client/commit/63f97f37daee37a725eb05df3097b20d5d4eaaf0)), closes [#963](https://www.github.com/googleapis/google-api-python-client/issues/963)
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@caltrops6490 caltrops6490 caltrops6490 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paul1319 @busunkim96 @caltrops6490 @googlebot