Support urllib3 >= 2.0.0 by danigm · Pull Request #1290 · googleapis/google-auth-library-python
requested a review
from a team
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request
May 19, 2023https://build.opensuse.org/request/show/1085995 by user dgarcia + dimstar_suse - Add urllib3-2.patch to support newer urllib3 -- gh#googleapis/google-auth-library-python#1290 - Remove no-python3.patch - Update to 2.17.3: * Add useEmailAzp claim for id token iam flow (#1270) (7a9c6f2) - 2.17.2: * Do not create new JWT credentials if they make the same claims as the existing. (#1267) (eebb7b6) - 2.17.1: * Print out reauth plugin error and raise if challenge output is None (#1265) (08d22fe) - 2.17.0: * Experimental service account iam endpoint flow for id token (#1258) (8ff0de5) * Python: Remove aws url validation (#1254) (20a966b) - 2.16.3: * Read both applicationId and relyingPartyId. (#1246) (e125dfe) - 2.16.2: * Call gcloud config get project to get project for user cred (#1243) (c078a13) * Do not use hardcoded string 'python', when yo
The urllib3.request.RequestMethods has been moved to urllib3._request_methods.RequestMethods. This patch changes the usage to continue working with the latest release, but now it's a "private" class in a "private" module, so maybe it's worth to start to think about updating this code to use the public API. https://urllib3.readthedocs.io/en/stable/changelog.html#removed
chalmerlowe pushed a commit that referenced this pull request
Dec 23, 2025The `urllib3.request` module was removed in urllib3 v2.0.0, and `RequestMethods` was moved to a private module `urllib3._request_methods`. This commit updates the docstrings in `google/auth/transport/urllib3.py` to remove references to the now-private `urllib3.request.RequestMethods` class. Instead, it references the public `urllib3.PoolManager` class or the generic request interface, ensuring the documentation remains accurate for both urllib3 v1 and v2 users. This addresses the documentation aspect of PR #1290.
chalmerlowe added a commit that referenced this pull request
Dec 26, 2025Updates docstrings in `google/auth/transport/urllib3.py` to reference `urllib3.PoolManager` instead of the removed/private `urllib3.request.RequestMethods`, ensuring compatibility with `urllib3` v2 documentation standards. NOTE: This PR supercedes an [older PR #1290](#1290), because some of the content or suggested changes in the older PR are overtaken by events and/or been incorporated via [other recent PRs](#1389). --- *PR created automatically by Jules for task [17649723998293325458](https://jules.google.com/task/17649723998293325458) started by @chalmerlowe* Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request
Mar 2, 2026Updates docstrings in `google/auth/transport/urllib3.py` to reference `urllib3.PoolManager` instead of the removed/private `urllib3.request.RequestMethods`, ensuring compatibility with `urllib3` v2 documentation standards. NOTE: This PR supercedes an [older PR #1290](googleapis/google-auth-library-python#1290), because some of the content or suggested changes in the older PR are overtaken by events and/or been incorporated via [other recent PRs](googleapis/google-auth-library-python#1389). --- *PR created automatically by Jules for task [17649723998293325458](https://jules.google.com/task/17649723998293325458) started by @chalmerlowe* Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters