samples(storage): Add region tags in fastbyte samples by v-pratap · Pull Request #15403 · googleapis/google-cloud-cpp
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.03%. Comparing base (b4bf27b) to head (51a9acd).
Additional details and impacted files
@@ Coverage Diff @@ ## main #15403 +/- ## ========================================== - Coverage 93.03% 93.03% -0.01% ========================================== Files 2403 2403 Lines 219441 219441 ========================================== - Hits 204148 204147 -1 - Misses 15293 15294 +1
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
| co_return (co_await std::move(c1)) + (co_await std::move(c2)); | ||
| }; | ||
| //! [open-object-multiple-ranged-read] | ||
| // [END storage_read_appendable_object_mulitple_ranges] |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: use multiple in region tag
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the PR title should be samples(storage) or chore(storage)
bajajneha27
changed the title
feat(storage): Add region tags in fastbyte samples
samples(storage): Add region tags in fastbyte samples
Please make sure to merge it with conventional commit samples instead of feat. We don't want this in our changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters