Home Original page

fix(storage): Increase AsyncWriter default MinLwmValue to avoid frequent flushes by shubham-up-47 · Pull Request #15552 · googleapis/google-cloud-cpp

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): Increase AsyncWriter default MinLwmValue to avoid frequent flushes #15552

Changes from all commits

Commits

File filter

Filter by extension

Conversations

Failed to load comments.

Loading

Jump to

Jump to file

Failed to load files.

Loading

Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ namespace storage_internal {
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
namespace {

std::size_t MinLwmValue() { return 256 * 1024; }
std::size_t MinLwmValue() { return 16 * 1024 * 1024; }

std::size_t MaxLwmValue() {
if (std::numeric_limits<std::size_t>::digits < 64) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -451,9 +451,9 @@ TEST_F(AsyncClientIntegrationTest, StartBufferedUploadEmpty) {
TEST_F(AsyncClientIntegrationTest, StartBufferedUploadMultiple) {
auto client = AsyncClient(TestOptions());
auto object_name = MakeRandomObjectName();
// Create a small block to send over and over.
auto constexpr kBlockSize = 256 * 1024;
auto constexpr kBlockCount = 16;
// Create a block to send over and over.
auto constexpr kBlockSize = 16 * 1024 * 1024;
auto constexpr kBlockCount = 3;
auto const block = MakeRandomData(kBlockSize);

auto w =
Expand Down