feat(storage): add GrpcMetricsExcludedLabelsOption for gRPC metrics label filtering by shubham-up-47 · Pull Request #15735 · googleapis/google-cloud-cpp

Summary of Changes

Hello @shubham-up-47, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement to gRPC telemetry by providing a mechanism to filter out specific OpenTelemetry resource attribute keys from metric labels before they are exported to Google Cloud Monitoring. This allows for more precise control over the data sent, potentially reducing noise and tailoring metrics to specific analytical needs. The changes involve adding a new configuration option, refactoring internal OpenTelemetry function types for broader use, and updating the metric exporter's internal logic to correctly apply these new filtering capabilities, ensuring robust and configurable telemetry data processing.

Highlights

  • New Option for gRPC Metrics Label Filtering: Introduced GrpcMetricsExcludedLabelsOption which allows users to specify a std::set<std::string> of OpenTelemetry resource attribute keys to be excluded from gRPC telemetry metric labels when exporting to Google Cloud Monitoring.
  • Refactoring of OpenTelemetry Types: The MonitoredResourceFromDataFn and ResourceFilterDataFn type aliases have been moved from the otel_internal namespace to the public otel namespace, making them accessible for configuration.
  • Enhanced Metric Exporter Logic: The MonitoringExporter now includes logic to ensure that if a ResourceFilterDataFn is provided, a MonitoredResourceFromDataFn is also available, creating a default one if necessary to support dynamic resource handling.
  • Flexible Filter Function Creation: A new utility function, MakeFilter, has been added to dynamically create the ResourceFilterDataFn based on either an explicitly provided filter function or the newly introduced GrpcMetricsExcludedLabelsOption.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.