Home Original page

fix(storage): Update offset on resumable upload retry by cjc25 · Pull Request #12086 · googleapis/google-cloud-go

@cjc25 

When resumable uploads retry, they may observe a flush offset which is
past the start of the current send (in fact the whole send might have
already completed). In that case, we avoided re-sending unnecessary
data, but we didn't update the offset to account for the data not sent.

@cjc25 cjc25 requested a review from a team

April 30, 2025 15:19

@cjc25 cjc25 changed the title fix: Update offset on resumable upload retry fix(storage): Update offset on resumable upload retry

Apr 30, 2025

@tritone

@tritone tritone added the automerge

Merge the pull request once unit tests and other checks pass.

label

Apr 30, 2025

@gcf-merge-on-green

@cjc25

@cjc25 cjc25 deleted the resumable-upload-grpc-fix branch

May 1, 2025 02:22

2FaceS-bit pushed a commit to 2FaceS-bit/google-cloud-go that referenced this pull request

May 12, 2025 
When resumable uploads retry, they may observe a flush offset which is past the start of the current send (in fact the whole send might have already completed). In that case, we avoided re-sending unnecessary data, but we didn't update the offset to account for the data not sent.