fix(telemetry): fix incorrect span titles and missing otelAttributes by ldetmer · Pull Request #12080 · googleapis/google-cloud-java

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@ldetmer

Copy link Copy Markdown

Contributor

@ldetmer ldetmer commented

Mar 13, 2026

In adding additional metrics it was noticed that some existing metrics are incorrect. This PR fixes the testIamPermissions and deleteRoutine span titles/rpc.methods to be correct. This also ensures we are adding otelAttributes to tracing (currently there was a bug where they were getting dropped.

ldetmer added 2 commits

March 13, 2026 15:46
…ace names/methods, as well as actually add otelAttributes to span

@ldetmer ldetmer requested review from a team as code owners

March 13, 2026 19:49

@ldetmer ldetmer requested review from jinseopkim0 and lqiu96

March 13, 2026 19:51

@ldetmer ldetmer enabled auto-merge (squash)

March 13, 2026 20:00

@ldetmer ldetmer merged commit f1c04a9 into main

Mar 13, 2026

56 checks passed

@ldetmer ldetmer deleted the fix-existing-telemetry branch

March 13, 2026 20:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeli0 blakeli0 blakeli0 approved these changes

@lqiu96 lqiu96 Awaiting requested review from lqiu96

@jinseopkim0 jinseopkim0 Awaiting requested review from jinseopkim0

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ldetmer @blakeli0