[BC Break] Add requestTimeout option to be shared between REST/gRPC by dwsupplee · Pull Request #390 · googleapis/google-cloud-php

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@dwsupplee

Copy link Copy Markdown

Contributor

Closes: #376

@googlebot googlebot added the cla: yes

This human has signed the Contributor License Agreement.

label

Mar 10, 2017

@jdpedrie jdpedrie changed the title Add requestTimeout option to be shared between REST/gRPC [BC Break] Add requestTimeout option to be shared between REST/gRPC

Mar 10, 2017

@jdpedrie

Copy link Copy Markdown

Contributor

BC Break: renamed httpOptions to restOptions.

@dwsupplee

Copy link Copy Markdown

Contributor Author

@jdpedrie rebased! PTAL

@dwsupplee dwsupplee merged commit 06cbd4c into googleapis:master

Mar 16, 2017

@dwsupplee dwsupplee deleted the request-timeout branch

March 16, 2017 15:37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jdpedrie jdpedrie jdpedrie approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: core cla: yes

This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dwsupplee @jdpedrie @googlebot