fix: remove redundant MetricsCapture from trace_call by waiho-gumloop · Pull Request #16495 · googleapis/google-cloud-python
Navigation Menu
- Notifications You must be signed in to change notification settings
- Fork 1.7k
Conversation
The bare MetricsCapture() inside trace_call creates a MetricsTracer without project_id or instance_id. Since every caller already provides its own MetricsCapture(resource_info) with correct labels, the one inside trace_call is redundant and records operation metrics with incomplete resource labels on every operation. Fixes googleapis#16173
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters