Add customer-supplied encryption to storage by daspecster · Pull Request #1844 · googleapis/google-cloud-python
Navigation Menu
{{ message }}
googleapis / google-cloud-python Public
- Notifications You must be signed in to change notification settings
- Fork 1.7k
Merged
daspecster merged 3 commits intogoogleapis:masterfrom
Jun 15, 2016Merged
Add customer-supplied encryption to storage#1844
daspecster merged 3 commits intogoogleapis:masterfrom
Add customer-supplied encryption to storage#1844
daspecster merged 3 commits intogoogleapis:masterfrom
Conversation
Copy link Copy Markdown
Contributor
daspecster
commented
Jun 7, 2016
daspecster
commented
Possible solution to resolve #1841.
I think my tests could use some feedback.
daspecster
added
type: feature request
labels
Jun 7, 2016
daspecster
assigned
dhermes
label
Jun 7, 2016
daspecster
force-pushed
the
customer-supplied-encryption
branch
from
0d91e0b to
f713c3e
Compare
Copy link Copy Markdown
Contributor Author
daspecster
commented
Jun 7, 2016
daspecster commented
Jun 7, 2016
gcloud/storage/blob.py
Outdated
gcloud/storage/blob.py Outdated
| """ | ||
| return bucket_path + '/o/' + quote(blob_name, safe='') | ||
|
|
||
| @staticmethod |
This comment was marked as spam.
This comment was marked as spam.
daspecster
force-pushed
the
customer-supplied-encryption
branch
2 times, most recently
from
737bf7e to
bfaf049
Compare
Copy link Copy Markdown
Contributor Author
daspecster
commented
Jun 9, 2016
daspecster commented
Jun 9, 2016|
|
||
| :type value: bytes | ||
| :param value: bytes value to attempt string conversion on. | ||
| """ |
This comment was marked as spam.
This comment was marked as spam.
daspecster
force-pushed
the
customer-supplied-encryption
branch
from
b4152a2 to
824bf93
Compare
Copy link Copy Markdown
Contributor Author
daspecster
commented
Jun 10, 2016
daspecster commented
Jun 10, 2016@dhermes I squashed the commits for this. Let me know if you have any other feedback.
gcloud/_helpers.py
Outdated
gcloud/_helpers.py Outdated
| raise TypeError('%r could not be converted to bytes' % (value,)) | ||
|
|
||
|
|
||
| def _from_bytes(value): |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 participants