Add 'BucketNotification.create' API wrapper. by tseaver · Pull Request #3966 · googleapis/google-cloud-python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

tseaver merged 1 commit intogoogleapis:3956-storage-notificationsfrom

tseaver:3956-storage-notifications-notification-create

Sep 15, 2017

Merged

Add 'BucketNotification.create' API wrapper.#3966

tseaver merged 1 commit intogoogleapis:3956-storage-notificationsfrom

tseaver:3956-storage-notifications-notification-create

Conversation

@tseaver

Copy link Copy Markdown

Contributor

@tseaver tseaver commented

Sep 15, 2017

Toward #3956.

@tseaver tseaver added api: storage

Issues related to the Cloud Storage API.

type: feature request

‘Nice-to-have’ improvement, new feature or different behavior or design.

labels

Sep 15, 2017

@googlebot googlebot added the cla: yes

This human has signed the Contributor License Agreement.

label

Sep 15, 2017
Copy link Copy Markdown

Contributor

@lukesneeringer lukesneeringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with the one question.

JSON_API_V1_PAYLOAD_FORMAT = 'JSON_API_V1'
NONE_PAYLOAD_FORMAT = 'NONE'

_TOPIC_REF = '//pubsub.googleapis.com/projects/{}/topics/{}'

This comment was marked as spam.

This comment was marked as spam.

@tseaver tseaver merged commit 49b6e7d into googleapis:3956-storage-notifications

Sep 15, 2017

@tseaver tseaver deleted the 3956-storage-notifications-notification-create branch

September 15, 2017 21:18

tseaver added a commit that referenced this pull request

Sep 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhermes dhermes Awaiting requested review from dhermes

1 more reviewer

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage

Issues related to the Cloud Storage API.

cla: yes

This human has signed the Contributor License Agreement.

type: feature request

‘Nice-to-have’ improvement, new feature or different behavior or design.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver @lukesneeringer @googlebot