Add 'Bucket.list_notifications' API wrapper. by tseaver · Pull Request #3990 · googleapis/google-cloud-python

Add 'Bucket.list_notifications' API wrapper. by tseaver · Pull Request #3990 · googleapis/google-cloud-python

Skip to content

Merged

tseaver merged 3 commits intogoogleapis:3956-storage-notificationsfrom

tseaver:3956-storage-notifications-bucket-list_notifications

Sep 21, 2017

Merged

Add 'Bucket.list_notifications' API wrapper.#3990
tseaver merged 3 commits intogoogleapis:3956-storage-notificationsfrom
tseaver:3956-storage-notifications-bucket-list_notifications

Conversation

Copy link Copy Markdown

Contributor

tseaver commented
Sep 18, 2017

Uses #3983 as a base.

Toward #3956.

tseaver added api: storage

Issues related to the Cloud Storage API.

type: feature request

‘Nice-to-have’ improvement, new feature or different behavior or design.

labels

tseaver requested review from dhermes and lukesneeringer

September 18, 2017 16:08

googlebot added the cla: yes

This human has signed the Contributor License Agreement.

label

tseaver mentioned this pull request

Add support for storage->pubsub notifications #3956

Closed

8 tasks

dhermes reviewed Sep 18, 2017

View reviewed changes

storage/google/cloud/storage/bucket.py Outdated

		return iterator

		def list_notifications(self, client=None):
		"""List pubsub notifications for this bucket.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

storage/google/cloud/storage/notification.py Outdated

		:returns: the new notification instance
		:raises ValueError:
		if resource is missing 'topic' key, or if it is not formatted
		per documented spec.

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

storage/google/cloud/storage/notification.py Outdated

		match = _TOPIC_REF_RE.match(topic_path)
		if match is None:
		raise ValueError(
		'Resource has invalid topic: {}'.format(topic_path))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver added 3 commits

September 18, 2017 14:52

Add 'BucketNotification.from_api_repr' factory.

Add 'Bucket.list_notifications' API wrapper.

Toward #3956.

Docstring / exception message fixes.

Addresses:
https://github.com/GoogleCloudPlatform/google-cloud-python/pull/3990/files#r139469973
https://github.com/GoogleCloudPlatform/google-cloud-python/pull/3990/files#r139470301
https://github.com/GoogleCloudPlatform/google-cloud-python/pull/3990/files#r139470379.

Copy link Copy Markdown

Contributor Author

tseaver commented
Sep 21, 2017

@dhermes Any remaining issues?

dhermes approved these changes Sep 21, 2017

View reviewed changes

Copy link Copy Markdown

Contributor

dhermes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tseaver merged commit 9eb9a46 into googleapis:3956-storage-notifications

tseaver deleted the 3956-storage-notifications-bucket-list_notifications branch

September 21, 2017 19:15

tseaver added a commit that referenced this pull request

Add 'Bucket.list_notifications' API wrapper. (#3990)

Toward #3956.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issues related to the Cloud Storage API.

This human has signed the Contributor License Agreement.

type: feature request

‘Nice-to-have’ improvement, new feature or different behavior or design.

3 participants