Translate: Add client options to translate_v2. by busunkim96 · Pull Request #8737 · googleapis/google-cloud-python

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@busunkim96

Copy link Copy Markdown

Contributor

Towards #8475.

@busunkim96 busunkim96 added the api: translation

Issues related to the Cloud Translation API API.

label

Jul 23, 2019

@googlebot googlebot added the cla: yes

This human has signed the Contributor License Agreement.

label

Jul 23, 2019

@busunkim96 busunkim96 force-pushed the translate-client-options branch from 3be2555 to f5cb28c Compare

July 29, 2019 17:24

@tseaver tseaver added the kokoro:force-run

Add this label to force Kokoro to re-run the tests.

label

Jul 29, 2019

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run

Add this label to force Kokoro to re-run the tests.

label

Jul 29, 2019
Copy link Copy Markdown

Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure seemed to be a race: google-cloud-core 1.0.3 wasn't yet available on PyPI. The docs job installs it from PyPI, rather than the local checkout.

@busunkim96 busunkim96 merged commit 3979e8b into googleapis:master

Jul 30, 2019

parthea pushed a commit that referenced this pull request

Oct 21, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: translation

Issues related to the Cloud Translation API API.

cla: yes

This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@busunkim96 @tseaver @googlebot @yoshi-kokoro