Chore: refactor client.download_blob_to_file by MiaCY · Pull Request #1052

Chore: refactor client.download_blob_to_file by MiaCY · Pull Request #1052 · googleapis/python-storage

added 3 commits

May 25, 2023 10:03

…rage into transfer_manager_usage_metrics

MiaCY added the do not merge

Indicates a pull request not ready for merge, due to either quality or timing.

label

May 25, 2023

…nto transfer_manager_usage_metrics

MiaCY removed the do not merge

Indicates a pull request not ready for merge, due to either quality or timing.

label

Jun 6, 2023

MiaCY marked this pull request as ready for review

June 7, 2023 20:39

MiaCY requested a review from a team

June 7, 2023 20:39

andrewsg pushed a commit that referenced this pull request

Sep 18, 2023

* Refactor client.download_blob_to_file

* Chore: clean up code

* refactor blob and client unit tests

* lint reformat

* Rename _prep_and_do_download

cojenco added a commit that referenced this pull request

Oct 19, 2023

* Chore: refactor client.download_blob_to_file (#1052)

* Refactor client.download_blob_to_file

* Chore: clean up code

* refactor blob and client unit tests

* lint reformat

* Rename _prep_and_do_download

* Chore: refactor blob.upload_from_file (#1063)

* Refactor client.download_blob_to_file

* Chore: clean up code

* refactor blob and client unit tests

* lint reformat

* Rename _prep_and_do_download

* Refactor blob.upload_from_file

* Lint reformat

* feature: add 'command' argument to private upload/download interface (#1082)

* Refactor client.download_blob_to_file

* Chore: clean up code

* refactor blob and client unit tests

* lint reformat

* Rename _prep_and_do_download

* Refactor blob.upload_from_file

* Lint reformat

* feature: add 'command' argument to private upload/download interface

* lint reformat

* reduce duplication and edit docstring

* feat: add support for custom headers starting with  metadata op

* add custom headers to downloads in client blob modules

* add custom headers to uploads with tests

* update mocks and tests

* test custom headers support tm mpu uploads

* update tm test

* update test

---------

Co-authored-by: MiaCY <97990237+MiaCY@users.noreply.github.com>