fix: silence expected errors for routine operations on BlobReader by andrewsg · Pull Request #400

fix: silence expected errors for routine operations on BlobReader by andrewsg · Pull Request #400 · googleapis/python-storage

requested a review from a team

March 29, 2021 17:19

google-cla bot added the cla: yes

This human has signed the Contributor License Agreement.

label

Mar 29, 2021

andrewsg added the automerge

Merge the pull request once unit tests and other checks pass.

label

Mar 29, 2021

cojenco pushed a commit to cojenco/python-storage that referenced this pull request

Oct 13, 2021

…ogleapis#400)

Two fixes for BlobReader:
- Checksums are not supported for BlobReader's chunked downloads, so set checksum=None to silence log warnings (and add a note to the docstring explaining this).
- In Python, read() on files at EOF should return an empty result, but not raise an error. Stop BlobReader from emitting RequestRangeNotSatisfiable errors at EOF.

Fixes: googleapis#399

cojenco pushed a commit to cojenco/python-storage that referenced this pull request

Oct 13, 2021

…ogleapis#400)

Two fixes for BlobReader:
- Checksums are not supported for BlobReader's chunked downloads, so set checksum=None to silence log warnings (and add a note to the docstring explaining this).
- In Python, read() on files at EOF should return an empty result, but not raise an error. Stop BlobReader from emitting RequestRangeNotSatisfiable errors at EOF.

Fixes: googleapis#399