fix: remove trailing commas from error message constants by rjw57 · Pull Request #505 · googleapis/python-storage

@rjw57 requested a review from a team

July 15, 2021 09:48

@google-cla google-cla bot added the cla: yes

This human has signed the Contributor License Agreement.

label

Jul 15, 2021

@parthea parthea changed the title blob.py: remove dangling comma in _DOWNLOAD_AS_STRING_DEPRECATED fix: TypeError in blob.download_as_string()

Jul 15, 2021

@parthea parthea changed the title fix: TypeError in blob.download_as_string() fix: TypeError in blob.download_as_string

Jul 15, 2021

@parthea parthea changed the title fix: TypeError in blob.download_as_string fix(Python 2.7): TypeError in blob.download_as_string

Jul 15, 2021

@parthea parthea changed the title fix(Python 2.7): TypeError in blob.download_as_string fix: TypeError in blob.download_as_string

Jul 15, 2021

tseaver

@tseaver tseaver changed the title fix: TypeError in blob.download_as_string fix: remove trailing commas from error message constants

Jul 15, 2021

@rjw57

The _DOWNLOAD_AS_STRING_DEPRECATED,
_COMPOSE_IF_GENERATION_LIST_DEPRECATED and
_COMPOSE_IF_GENERATION_LIST_AND_IF_SOURCE_GENERATION_ERROR constants
include a dangling comma which make them tuples and not strings. This
causes a TypeError as reported in googleapis#501.

Closes googleapis#501

@tseaver tseaver added the automerge

Merge the pull request once unit tests and other checks pass.

label

Jul 15, 2021

@tseaver

cojenco pushed a commit to cojenco/python-storage that referenced this pull request

Oct 13, 2021
)

The _DOWNLOAD_AS_STRING_DEPRECATED constant includes a dangling comma
which makes it a tuple and not a string. This causes a TypeError as reported in googleapis#501.

Fixes googleapis#501

cojenco pushed a commit to cojenco/python-storage that referenced this pull request

Oct 13, 2021
)

The _DOWNLOAD_AS_STRING_DEPRECATED constant includes a dangling comma
which makes it a tuple and not a string. This causes a TypeError as reported in googleapis#501.

Fixes googleapis#501