refactor: replace deprecated String.prototype.substr() by CommanderRoot · Pull Request #747 · gpujs/gpu.js
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 663
Open
CommanderRoot wants to merge 1 commit intogpujs:developfrom
Open
refactor: replace deprecated String.prototype.substr()#747
CommanderRoot wants to merge 1 commit intogpujs:developfrom
refactor: replace deprecated String.prototype.substr()#747
CommanderRoot wants to merge 1 commit intogpujs:developfrom
Conversation
Copy link Copy Markdown
CommanderRoot
commented
Mar 25, 2022
CommanderRoot
commented
String.prototype.substr() is deprecated so we replace it with String.prototype.slice() which works similarily but isn't deprecated.
.substr() probably isn't going away anytime soon but the change is trivial so it doesn't hurt to do it.
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant