Add minmax-sampling feature by kvark · Pull Request #1283 · gpuweb/gpuweb

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Draft

Add minmax-sampling feature#1283

kvark wants to merge 4 commits intogpuweb:mainfrom

kvark:minmax

Conversation

@kvark

Copy link

Contributor

@kvark kvark commented

Dec 8, 2020

edited by pr-preview bot

Loading

Closes #1267

This is useful for building hierarchical depth bounds, as one example.

Hardware support:

Note: min/max sampling shouldn't be considered "filtering" for the purpose of validation.

TODO:

  • figure out which formats support this, potentially add a column to our format table.
  • determine if it's a filter mode, or something entirely different. Can a sampler be linearly magnifying but minmaxing the minification? In D3D12 it can, it seems, but maybe we don't need that.
  • determine if a separate sampler binding type is needed

Preview | Diff

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kangz Kangz Kangz left review comments

@kainino0x kainino0x kainino0x approved these changes

Assignees

No one assigned

Labels

api

WebGPU API

feature request

A request for a new GPU feature exposed in the API

Projects

None yet

Milestone

Milestone 4+

Development

Successfully merging this pull request may close these issues.

Integer Sampling & Sampler Reduction Modes

3 participants

@kvark @Kangz @kainino0x