Disable form post by default by Shane32 · Pull Request #1139 · graphql-dotnet/server

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Shane32

Copy link

Member

@Shane32 Shane32 commented

Aug 4, 2024

Form post requests are not recommended, mostly due to CSRF concerns. Also the draft GraphQL-over-HTTP specification does not define the format of such a request. Since v7 we have stated that form post requests would be disabled by default in future versions. This PR disables form post requests by default.

@Shane32 Shane32 added this to the 8.0 milestone

Aug 4, 2024

@Shane32 Shane32 self-assigned this

Aug 4, 2024

@Shane32 Shane32 requested a review from gao-artur

August 4, 2024 05:10

@Shane32 Shane32 linked an issue

Aug 4, 2024

that may be closed by this pull request

@Shane32 Shane32 merged commit c48d21a into develop

Aug 4, 2024

@Shane32 Shane32 deleted the disable_form_post branch

August 4, 2024 05:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gao-artur gao-artur gao-artur approved these changes

Assignees

@Shane32 Shane32

Labels

None yet

Projects

None yet

Milestone

8.0

Development

Successfully merging this pull request may close these issues.

Disable ReadFormOnPost by default

2 participants

@Shane32 @gao-artur