OSGI - Make org.jspecify.* imports optional by schulm · Pull Request #3949 · graphql-java/graphql-java
Navigation Menu
{{ message }}
graphql-java / graphql-java Public
- Notifications You must be signed in to change notification settings
- Fork 1.1k
Merged
bbakerman merged 1 commit intographql-java:masterfrom
May 6, 2025Merged
OSGI - Make org.jspecify.* imports optional#3949
bbakerman merged 1 commit intographql-java:masterfrom
OSGI - Make org.jspecify.* imports optional#3949
bbakerman merged 1 commit intographql-java:masterfrom
Conversation
Copy link
schulm
commented
May 5, 2025
schulm
commented
Since org.specify import is not necessarily needed at runtime, can we make it optional?
Copy link
Member
andimarek
commented
May 5, 2025
andimarek commented
May 5, 2025@schulm sounds reasonable.
@dondonz @bbakerman thoughts?
Copy link
Member
bbakerman
commented
May 6, 2025
bbakerman commented
May 6, 2025Yeah we should add this.
bbakerman
self-requested a review
bbakerman approved these changes May 6, 2025
Copy link
Member
bbakerman
left a comment
bbakerman
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not many use OSGI any more but why not
bbakerman
added this to the
24.0 milestone
Copy link
Author
schulm
commented
May 6, 2025
schulm commented
May 6, 2025@bbakerman Thanks, would you also have a look at graphql-java/java-dataloader#194
schulm
mentioned this pull request
Closed
dondonz added a commit that referenced this pull request
May 13, 2025
dondonz
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants