add method to parse field definition from Parser by andimarek · Pull Request #4006 · graphql-java/graphql-java
Navigation Menu
{{ message }}
graphql-java / graphql-java Public
- Notifications You must be signed in to change notification settings
- Fork 1.1k
Merged
add method to parse field definition from Parser#4006
add method to parse field definition from Parser#4006
Conversation
andimarek
added this to the
25.x breaking changes milestone
Copy link
Contributor
github-actions
bot
commented
Jun 8, 2025
github-actions bot commented
Jun 8, 2025Test Results
318 files 318 suites 2m 32s ⏱️
4 685 tests 4 676 ✅ 9 💤 0 ❌
4 774 runs 4 765 ✅ 9 💤 0 ❌
Results for commit c4c1b51.
bbakerman reviewed Jun 9, 2025
| 'foo(a:String!,b:Int!): Foo' | _ | ||
| 'foo(a:String! ="defaultValue",b:Int!): Foo' | _ | ||
| 'foo(a:String!,b:Int!): Foo @directive(someValue:String)' | _ | ||
| } |
Copy link
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the failure case - what happens when it fails to parse? Will it throw and exception and if so lets lock that in with a test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants