Fix IncrementalExecutionResult.transform() to preserve incremental fields by AndreaRomani · Pull Request #4073 · graphql-java/graphql-java
Navigation Menu
{{ message }}
graphql-java / graphql-java Public
- Notifications You must be signed in to change notification settings
- Fork 1.1k
Merged
bbakerman merged 1 commit intographql-java:masterfrom
Aug 11, 2025Merged
Conversation
Copy link
Contributor
AndreaRomani
commented
Jul 31, 2025
AndreaRomani
commented
Summary
Fixes the transform() method in IncrementalExecutionResultImpl to return an IncrementalExecutionResult that preserves all incremental-specific field values instead of losing them.
Changes
- Updated
IncrementalExecutionResultImpl.transform()to preserveincremental,hasNext, andincrementalPublisherfields - Improved
IncrementalExecutionResultTestwith comprehensive test coverage for the transform behavior
Fixes #4072
bbakerman approved these changes Aug 2, 2025
Copy link
Member
bbakerman
left a comment
bbakerman
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this
bbakerman
added this to the
25.x breaking changes milestone
This comment was marked as off-topic.
This comment was marked as off-topic.
Copy link
Member
dondonz
commented
Aug 3, 2025
dondonz commented
Aug 3, 2025@bbakerman was that comment intended for another thread?
Copy link
Member
bbakerman
commented
Aug 5, 2025
bbakerman commented
Aug 5, 2025Yes it was - I have hidden the comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants