remove unnecessary synchronized by andimarek · Pull Request #4138 · graphql-java/graphql-java
Expand Up
@@ -47,18 +47,16 @@ public CompletableFuture<List<V>> loadMany(List<K> keys, List<Object> keyContext
assertNotNull(keyContexts);
CompletableFuture<List<V>> result; synchronized (this) { List<CompletableFuture<V>> collect = new ArrayList<>(keys.size()); for (int i = 0; i < keys.size(); i++) { K key = keys.get(i); Object keyContext = null; if (i < keyContexts.size()) { keyContext = keyContexts.get(i); } collect.add(delegate.load(key, keyContext)); List<CompletableFuture<V>> collect = new ArrayList<>(keys.size()); for (int i = 0; i < keys.size(); i++) { K key = keys.get(i); Object keyContext = null; if (i < keyContexts.size()) { keyContext = keyContexts.get(i); } result = Async.allOf(collect); collect.add(delegate.load(key, keyContext)); } result = Async.allOf(collect); newDataLoaderInvocation(); return result; } Expand All @@ -68,15 +66,13 @@ public CompletableFuture<Map<K, V>> loadMany(Map<K, ?> keysAndContexts) { assertNotNull(keysAndContexts);
CompletableFuture<Map<K, V>> result; synchronized (this) { Map<K, CompletableFuture<V>> collect = new HashMap<>(keysAndContexts.size()); for (Map.Entry<K, ?> entry : keysAndContexts.entrySet()) { K key = entry.getKey(); Object keyContext = entry.getValue(); collect.put(key, delegate.load(key, keyContext)); } result = Async.allOf(collect); Map<K, CompletableFuture<V>> collect = new HashMap<>(keysAndContexts.size()); for (Map.Entry<K, ?> entry : keysAndContexts.entrySet()) { K key = entry.getKey(); Object keyContext = entry.getValue(); collect.put(key, delegate.load(key, keyContext)); } result = Async.allOf(collect); newDataLoaderInvocation(); return result; } Expand All @@ -95,6 +91,4 @@ private void newDataLoaderInvocation() { }
}
CompletableFuture<List<V>> result; synchronized (this) { List<CompletableFuture<V>> collect = new ArrayList<>(keys.size()); for (int i = 0; i < keys.size(); i++) { K key = keys.get(i); Object keyContext = null; if (i < keyContexts.size()) { keyContext = keyContexts.get(i); } collect.add(delegate.load(key, keyContext)); List<CompletableFuture<V>> collect = new ArrayList<>(keys.size()); for (int i = 0; i < keys.size(); i++) { K key = keys.get(i); Object keyContext = null; if (i < keyContexts.size()) { keyContext = keyContexts.get(i); } result = Async.allOf(collect); collect.add(delegate.load(key, keyContext)); } result = Async.allOf(collect); newDataLoaderInvocation(); return result; } Expand All @@ -68,15 +66,13 @@ public CompletableFuture<Map<K, V>> loadMany(Map<K, ?> keysAndContexts) { assertNotNull(keysAndContexts);
CompletableFuture<Map<K, V>> result; synchronized (this) { Map<K, CompletableFuture<V>> collect = new HashMap<>(keysAndContexts.size()); for (Map.Entry<K, ?> entry : keysAndContexts.entrySet()) { K key = entry.getKey(); Object keyContext = entry.getValue(); collect.put(key, delegate.load(key, keyContext)); } result = Async.allOf(collect); Map<K, CompletableFuture<V>> collect = new HashMap<>(keysAndContexts.size()); for (Map.Entry<K, ?> entry : keysAndContexts.entrySet()) { K key = entry.getKey(); Object keyContext = entry.getValue(); collect.put(key, delegate.load(key, keyContext)); } result = Async.allOf(collect); newDataLoaderInvocation(); return result; } Expand All @@ -95,6 +91,4 @@ private void newDataLoaderInvocation() { }
}