Making DataLoaderOptions immutable by bbakerman · Pull Request #176 · graphql-java/java-dataloader
Navigation Menu
{{ message }}
graphql-java / java-dataloader Public
- Notifications You must be signed in to change notification settings
- Fork 97
Merged
Conversation
Copy link
Member
bbakerman
commented
Jan 30, 2025
bbakerman
commented
DataLoaderOptions was not immutable and this can lead to bugs now that we have DataLoader + builders + transformation
dondonz approved these changes Feb 1, 2025
| statisticsCollector = NOOP_COLLECTOR; | ||
| environmentProvider = NULL_PROVIDER; | ||
| valueCacheOptions = ValueCacheOptions.newOptions(); | ||
| valueCacheOptions = DEFAULT_VALUE_CACHE_OPTIONS; |
Copy link
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
dondonz
added
the
breaking change
label
andimarek approved these changes Feb 20, 2025
dondonz
added this to the
4.0.0 milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment