Added a instrumentation of load calls by bbakerman · Pull Request #178 · graphql-java/java-dataloader

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@bbakerman

Copy link

Member

The Insrtrumentation calls did not cover load calls. This adds that

@bbakerman bbakerman added this to the 4.0.0 milestone

Mar 11, 2025
*/
default DataLoaderInstrumentationContext<Object> beginLoad(DataLoader<?, ?> dataLoader, Object key, Object loadContext) {
return null;
}
Copy link

Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would allow some to "see" all DL load calls

@bbakerman bbakerman merged commit 212049c into master

Apr 2, 2025

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andimarek andimarek andimarek approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@bbakerman @andimarek