Added a loadImpl function to allow delegate overriding better by bbakerman · Pull Request #240 · graphql-java/java-dataloader
Navigation Menu
{{ message }}
graphql-java / java-dataloader Public
- Notifications You must be signed in to change notification settings
- Fork 97
Merged
Added a loadImpl function to allow delegate overriding better#240
Added a loadImpl function to allow delegate overriding better#240
Conversation
Copy link
Member
bbakerman
commented
Oct 14, 2025
bbakerman
commented
Allows delegates to have side effects in their load and loadMany methods more easily without having to copy code
andimarek reviewed Oct 14, 2025
| } | ||
|
|
||
|
|
||
| private CompletableFuture<V> loadImpl(@NonNull K key, @Nullable Object keyContext) { |
Copy link
Member
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should that be protected?
andimarek approved these changes Oct 14, 2025
Copy link
Member
andimarek
left a comment
andimarek
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one method maybe protected, but otherwise 👍
…-handling # Conflicts: # src/main/java/org/dataloader/DataLoader.java
bbakerman
added this to the
6.0.0 milestone
bbakerman added 2 commits
October 27, 2025 10:16…-handling # Conflicts: # src/main/java/org/dataloader/DataLoader.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants