Updated the documentation of the CacheMap and also some refactoring by bbakerman · Pull Request #244 · graphql-java/java-dataloader
Navigation Menu
{{ message }}
graphql-java / java-dataloader Public
- Notifications You must be signed in to change notification settings
- Fork 97
Conversation
Copy link
Member
bbakerman
commented
Oct 26, 2025
bbakerman
commented
Just to explain the CAS atomic load requirement more
bbakerman
added this to the
6.0.0 milestone
bbakerman commented Oct 26, 2025
| ctx.onDispatched(); | ||
| cachedFuture.whenComplete(ctx::onCompleted); | ||
| return cachedFuture; | ||
| } |
Copy link
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code was common in 3 spots
bbakerman commented Oct 26, 2025
| assertThat(cacheMap.containsKey(1), equalTo(false)); | ||
| assertThat(cacheMap.containsKey(2), equalTo(false)); | ||
| assertThat(cacheMap.containsKey(3), equalTo(false)); | ||
| assertThat(cacheMap.containsKey(4), equalTo(false)); |
Copy link
Member Author
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some more tests for coverage reasons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants