Introduced optional_fields to SerializationMutation by rganeyev · Pull Request #1080 · graphql-python/graphene-django
Navigation Menu
{{ message }}
graphql-python / graphene-django Public
- Notifications You must be signed in to change notification settings
- Fork 766
Merged
zbyte64 merged 4 commits intographql-python:v2from
Jan 2, 2021Merged
Introduced optional_fields to SerializationMutation#1080
zbyte64 merged 4 commits intographql-python:v2from
Introduced optional_fields to SerializationMutation#1080
zbyte64 merged 4 commits intographql-python:v2from
Conversation
Copy link
Contributor
rganeyev
commented
Dec 27, 2020
rganeyev
commented
Added optional_fields to SerializationMutation to forcefully mark some fields as optional
… fields as optional
rganeyev
mentioned this pull request
Copy link
sebslomski
commented
Dec 29, 2020
sebslomski commented
Dec 29, 2020Please merge, it's an excellent addition! Thanks!
Copy link
Collaborator
zbyte64
commented
Dec 31, 2020
zbyte64 commented
Dec 31, 2020I don't have any objection to the feature. But please add some tests.
zbyte64
changed the base branch from
master
to
v2
rganeyev added 2 commits
December 31, 2020 11:35
Copy link
Contributor Author
rganeyev
commented
Dec 31, 2020
rganeyev commented
Dec 31, 2020@zbyte64, added two tests: when optional_fields is not set and optional_fields meta is set. Please review
zbyte64 requested changes Jan 1, 2021
Copy link
Collaborator
zbyte64
left a comment
zbyte64
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one comment, looks good otherwise
graphene_django/rest_framework/tests/test_mutation.py
Outdated
Show resolved
Hide resolved
graphene_django/rest_framework/tests/test_mutation.py Outdated Show resolved Hide resolved
rganeyev
requested a review
from zbyte64
zbyte64 approved these changes Jan 2, 2021
Copy link
Collaborator
zbyte64
left a comment
zbyte64
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
zbyte64
merged commit
1281c13
into
graphql-python:v2
Copy link
Contributor
mahmoudmostafa0
commented
Aug 24, 2023
mahmoudmostafa0 commented
Aug 24, 2023why this feature is remove now ?
kiendang
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants