Fix backward compability on GraphQLTestCase._client setter (v2) by ulgens · Pull Request #1093 · graphql-python/graphene-django
Navigation Menu
{{ message }}
graphql-python / graphene-django Public
- Notifications You must be signed in to change notification settings
- Fork 766
Merged
Fix backward compability on GraphQLTestCase._client setter (v2)#1093
Fix backward compability on GraphQLTestCase._client setter (v2)#1093
Conversation
Copy link
Collaborator
ulgens
commented
Jan 9, 2021
ulgens
commented
I didn't handle backward compatability for setter in https://github.com/graphql-python/graphene-django/pull/1084/files#r549921387 and it seems it caused problems for several users.
Relates to #1088, hopefully fixes it 🙂
ulgens
requested a review
from zbyte64
ulgens
changed the title
Fix backward compability on GraphQLTestCase._client setter
Fix backward compability on GraphQLTestCase._client setter (v2)
ulgens
mentioned this pull request
zbyte64 approved these changes Jan 9, 2021
Copy link
Collaborator
zbyte64
left a comment
zbyte64
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this will allow people to set _client and fix the problem for most it seems. Cool 👍
zbyte64
merged commit
e24675e
into
v2
zbyte64
deleted the
fix_backward_comp_test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants